Adapt ignore error message

[greg0ire]

Looks like the "of object" part is no longer mentioned in recent PHPStan versions.

[greg0ire]

Now there is a broken Psalm build 🤦‍♂️
And I cannot reproduce it on the playground, which seems to be using the master branch for some reason. Trying to get help on this at https://symfony-devs.slack.com/archives/C8SFXTD2M/p1702073197631449

[greg0ire]

The alternative here is to add $error = null; before this line:

instantiator/src/Doctrine/Instantiator/Instantiator.php

Line 169 in f49f6a8

set_error_handler(static function (int $code, string $message, string $file, int $line) use ($reflectionClass, &$error): bool {

, but although it is surprising to have this undeclared variable being used here (at least to me), apparently, it works just fine.

[SenseException]

I wanted to test that and clone the repository, but it seems you already did that a minute ago 😄

[SenseException]

I personally would have preferred $error = null; as it doesn't need the addition to the psalm config.

[greg0ire]

Yeah but that config is meant to go away in the (far?) future, and we probably would not think of removing that unneeded null initialization. Plus, if we can avoid touching working code for wrong reasons, it's probably best, right?

[SenseException]

if we can avoid touching working code for wrong reasons, it's probably best, right?

I agree with this and that's why I ✅ it.