Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-8471] Deprecate Partial DQL syntax and forcing partial loads. #8472

Merged
merged 3 commits into from
Feb 28, 2021

Conversation

beberlei
Copy link
Member

Deprecates when you SELECT PARTIAL and when you use the query hint Query::HINT_FORCE_PARTIAL_LOAD.

Fixes #8471

@beberlei beberlei modified the milestones: 2.8.2, 2.9.0 Feb 12, 2021
@SenseException
Copy link
Member

Should the message contain the SELECT NEW alternative that can replace partial objects?

@beberlei
Copy link
Member Author

@SenseException My idea would be that people click the link, which then shows the alternative. Its not so easy to explain in the short space available for the message.

@SenseException
Copy link
Member

What if we keep that information in the documentation? Your current doc-changes don't contain the alternative and I would expect to find it there if not in a deprecation message.

greg0ire
greg0ire previously approved these changes Feb 13, 2021
@beberlei beberlei merged commit b4e6530 into doctrine:2.9.x Feb 28, 2021
@beberlei beberlei deleted the DeprecatePartialObjects branch February 28, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants