Fix RuntimeReflectionProperty not working with static properties #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Sep 29, 2025
| public function setValue($object, $value = null) | ||
| { | ||
| if (! ($object instanceof Proxy && ! $object->__isInitialized())) { | ||
| if ((! ($object instanceof Proxy && ! $object->__isInitialized())) || $this->isStatic()) { |
There was a problem hiding this comment.
The extra parenthesis are not necessary. You can switch the operands to remove any ambiguity.
Suggested change
| if ((! ($object instanceof Proxy && ! $object->__isInitialized())) || $this->isStatic()) { | |
| if ($this->isStatic() || ! ($object instanceof Proxy && ! $object->__isInitialized())) { |
|
I've seen your comment #420 (comment), I think PR can be closed? Could you open an issue on doctrine/mongodb-odm ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420.
My assumption here is that using the native
ReflectionPropertyfor static properties won't cause the lazy proxy classes to get instantiated. The tests seem to confirm that.