Merge pull request #615 from doctrine/pre_bind_translation

Added preBind translation
doctrine · Mar 24, 2015 · d3c7808 · d3c7808
2 parents 69cfbdc + b8e3519
commit d3c7808
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/lib/Doctrine/ODM/PHPCR/Event.php b/lib/Doctrine/ODM/PHPCR/Event.php
@@ -40,6 +40,7 @@ final class Event
 
     const postLoadTranslation = 'postLoadTranslation';
     const preCreateTranslation = 'preCreateTranslation';
+    const preUpdateTranslation = 'preUpdateTranslation';
     const preRemoveTranslation = 'preRemoveTranslation';
     const postRemoveTranslation = 'postRemoveTranslation';
 
@@ -55,6 +56,7 @@ final class Event
         self::postLoad => self::postLoad,
         self::postLoadTranslation => self::postLoadTranslation,
         self::preCreateTranslation => self::preCreateTranslation,
+        self::preUpdateTranslation => self::preUpdateTranslation,
         self::preRemoveTranslation => self::preRemoveTranslation,
         self::postRemoveTranslation => self::postRemoveTranslation,
     );

diff --git a/lib/Doctrine/ODM/PHPCR/UnitOfWork.php b/lib/Doctrine/ODM/PHPCR/UnitOfWork.php
@@ -753,6 +753,14 @@ private function doBindTranslation($document, $locale, ClassMetadata $class)
                 new LifecycleEventArgs($document, $this->dm),
                 $invoke
             );
+        } elseif ($invoke = $this->eventListenersInvoker->getSubscribedSystems($class, Event::preUpdateTranslation)) {
+            $this->eventListenersInvoker->invoke(
+                $class,
+                Event::preUpdateTranslation,
+                $document,
+                new LifecycleEventArgs($document, $this->dm),
+                $invoke
+            );
         }
 
         $this->setLocale($document, $class, $locale);

diff --git a/tests/Doctrine/Tests/ODM/PHPCR/Functional/EventComputingTest.php b/tests/Doctrine/Tests/ODM/PHPCR/Functional/EventComputingTest.php
@@ -116,6 +116,7 @@ public function testComputingBetweenEventsWithTranslation()
              ->addEventListener(
                 array(
                     Event::preCreateTranslation,
+                    Event::preUpdateTranslation,
                     Event::postLoadTranslation,
                     Event::preRemoveTranslation,
                     Event::postRemoveTranslation,
@@ -142,8 +143,13 @@ public function testComputingBetweenEventsWithTranslation()
         // name had been changed pre binding translation
         $this->assertEquals('preCreateTranslation', $user->name);
 
+        $this->dm->bindTranslation($user, 'en');
+        // name has been changed when translation was updated
+        $this->assertEquals('preUpdateTranslation', $user->name);
+
         $this->dm->name = 'neuer Name';
         $this->dm->bindTranslation($user, 'de');
+
         $this->dm->flush();
         $this->dm->clear();
 
@@ -215,6 +221,12 @@ public function preCreateTranslation(LifecycleEventArgs $e)
         $document->name = 'preCreateTranslation';
     }
 
+    public function preUpdateTranslation(LifecycleEventArgs $e)
+    {
+        $document = $e->getObject();
+        $document->name = 'preUpdateTranslation';
+    }
+
     public function postLoadTranslation(LifecycleEventArgs $e)
     {
         $document = $e->getObject();