-
Notifications
You must be signed in to change notification settings - Fork 5
Update 'Granting Dodona Access' sections to reflect automated GitHub invitation acceptance #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Granting Dodona Access' sections to reflect automated GitHub invitation acceptance #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates documentation to reflect automated GitHub invitation acceptance, replacing previous manual process information. This change aligns the documentation with the new automated system implemented for handling collaboration invites.
- Replaces references to manual invitation acceptance with automated process
- Updates timing expectations from indefinite wait to up to 30 minutes
- Modifies warning box titles and content to reflect the new process
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
nl/guides/exercises/creating-exercises/setup/index.md | Updates Dutch documentation warning from manual to automated process |
en/guides/exercises/creating-exercises/setup/index.md | Updates English documentation warning from manual to automated process |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This should probably also be added on https://docs.dodona.be/en/guides/exercises/new-exercise-repo/ and https://docs.dodona.be/nl/guides/exercises/new-exercise-repo/ |
What happens at this moment for UGent Github/Github enterprise/Gitlab invites? Do we manually accept those? |
Both for UGent GitHub and Gitlab we do not need to accept but are added automatically. I would assume that for other GitHub Enterprise instances this would be the same. |
b8acff7
to
5019d25
Compare
…invitation acceptance With some delay
5019d25
to
c8c2722
Compare
Related to https://github.com/dodona-edu/dodona/issues/6144, updates the docs now that we have automated collaboration invite acceptance again.
We schedule the jobs every 10 minutes, but this is just an indication to GitHub. Looking at the latest runs, it can take up to +- 25 minutes in between runs, so mentioning 30 gives the user an indication while also not overpromising the time it can take.
Open for any rewordings, this is the best GPT 4.1 could come up with that I found acceptable 😄