Skip to content

Conversation

TomNaessens
Copy link
Contributor

@TomNaessens TomNaessens commented Oct 2, 2025

Related to https://github.com/dodona-edu/dodona/issues/6144, updates the docs now that we have automated collaboration invite acceptance again.

We schedule the jobs every 10 minutes, but this is just an indication to GitHub. Looking at the latest runs, it can take up to +- 25 minutes in between runs, so mentioning 30 gives the user an indication while also not overpromising the time it can take.

image

Open for any rewordings, this is the best GPT 4.1 could come up with that I found acceptable 😄

@TomNaessens TomNaessens requested a review from Copilot October 2, 2025 15:03
@TomNaessens TomNaessens self-assigned this Oct 2, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates documentation to reflect automated GitHub invitation acceptance, replacing previous manual process information. This change aligns the documentation with the new automated system implemented for handling collaboration invites.

  • Replaces references to manual invitation acceptance with automated process
  • Updates timing expectations from indefinite wait to up to 30 minutes
  • Modifies warning box titles and content to reflect the new process

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
nl/guides/exercises/creating-exercises/setup/index.md Updates Dutch documentation warning from manual to automated process
en/guides/exercises/creating-exercises/setup/index.md Updates English documentation warning from manual to automated process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TomNaessens TomNaessens added the enhancement New feature or request label Oct 2, 2025
@TomNaessens TomNaessens requested review from bmesuere and chvp October 2, 2025 15:09
@bmesuere
Copy link
Member

bmesuere commented Oct 2, 2025

This should probably also be added on https://docs.dodona.be/en/guides/exercises/new-exercise-repo/ and https://docs.dodona.be/nl/guides/exercises/new-exercise-repo/

@TomNaessens
Copy link
Contributor Author

This should probably also be added on https://docs.dodona.be/en/guides/exercises/new-exercise-repo/ and https://docs.dodona.be/nl/guides/exercises/new-exercise-repo/

What happens at this moment for UGent Github/Github enterprise/Gitlab invites? Do we manually accept those?

@chvp
Copy link
Member

chvp commented Oct 6, 2025

Both for UGent GitHub and Gitlab we do not need to accept but are added automatically. I would assume that for other GitHub Enterprise instances this would be the same.

@TomNaessens TomNaessens force-pushed the feat/update-docs-for-automated-invitation-acceptance-with-delay branch 2 times, most recently from b8acff7 to 5019d25 Compare October 6, 2025 12:59
@TomNaessens TomNaessens force-pushed the feat/update-docs-for-automated-invitation-acceptance-with-delay branch from 5019d25 to c8c2722 Compare October 6, 2025 13:03
@TomNaessens TomNaessens merged commit 956818d into main Oct 7, 2025
1 check passed
@TomNaessens TomNaessens deleted the feat/update-docs-for-automated-invitation-acceptance-with-delay branch October 7, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants