Add pytests to CMake Test matrix #411
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - includes pytests listed under tests/python/ dir in the CMake test matrix. Though the unit tests exited, they were never executed. - Fixes the deprectated pytest methods. Signed-off-by: Dinesh Prasanth M K <[email protected]>
SilleBille
added
Enhancement
SilleBille
added
the
Help Wanted
|
Hmmm. pytest fails because it fails to access the modules.. The packages are not installed yet and so, the test fails. Any thoughts? @edewata @cipherboy |
|
digging deeper, this can be achieved using tox. We have several The only caveat is that, it's difficult for me to add this to CMake. Do you oppose executing pytest in spec files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
includes pytests under tests/python/ dir in the CMake test matrix.
Though the unit tests exited, they were never executed.
Fixes the deprecated pytest methods.
Note
The pytests were added to the CMake test matrix instead of adding them
to the spec file. This ensures that the pytests are executed in other platforms
(Debian).
Signed-off-by: Dinesh Prasanth M K <[email protected]>