Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop DRMTool #4484

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Drop DRMTool #4484

merged 1 commit into from
Jun 21, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jun 20, 2023

The DRMTool command, its config file, and its manual page are actually just links to their counterparts in KRATool. Some of those links are actually broken, but rpminspect is only generating warnings for broken links instead of failing. Since the tool has long been deprecated the tool and the links can be dropped.

https://github.com/edewata/pki/blob/build/docs/changes/v11.5.0/Tools-Changes.adoc

Note: rpminspect is failing but it seems to be unrelated.

The DRMTool command, its config file, and its manual page are
actually just links to their counterparts in KRATool. Some of
those links are actually broken, but rpminspect is only
generating warnings instead of failing. Since the tool has
long been deprecated the tool and the links can be dropped.
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ckelleyRH ckelleyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rpminspect failure is almost certainly unrelated, will investigate. The COPR build still failing for RHEL 9 of course, will consider that separately too.

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jun 21, 2023

@ckelleyRH @fmarco76 Thanks!

@edewata edewata merged commit 456e81a into dogtagpki:master Jun 21, 2023
144 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants