Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-initialize ACME application #4486

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Auto-initialize ACME application #4486

merged 1 commit into from
Jun 23, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jun 22, 2023

The ACME webapp has been modified to automatically initialize the ACME application without an explicit dependency on RESTEasy. Since a JAX-RS application cannot have an empty path, the ACME application needs to be relocated to /rest and the endpoints need to be mapped to the new location as well.

https://docs.jboss.org/resteasy/docs/3.0.24.Final/userguide/html_single/#d4e143
https://stackoverflow.com/questions/10874188/jax-rs-application-on-the-root-context-how-can-it-be-done

The ACME webapp has been modified to automatically initialize
the ACME application without an explicit dependency on RESTEasy.
Since a JAX-RS application cannot have an empty path, the ACME
application needs to be relocated to /rest and the endpoints need
to be mapped to the new location as well.

https://docs.jboss.org/resteasy/docs/3.0.24.Final/userguide/html_single/#d4e143
https://stackoverflow.com/questions/10874188/jax-rs-application-on-the-root-context-how-can-it-be-done
@edewata edewata changed the title Auto-initialize ACME services Auto-initialize ACME application Jun 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ckelleyRH ckelleyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working through all these changes it is a big effort.

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jun 23, 2023

@ckelleyRH @fmarco76 Thanks!

@edewata edewata merged commit 994d932 into dogtagpki:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants