Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read IPs from SSLEngine session #4487

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

fmarco76
Copy link
Member

When SSLEngine is used IPs cannot be retrieved from the socket or stream proxies so they are stored into the SSLEngine session.

This is an extension to the standard because the SSLEngine should be unaware of the underlying communication but it is needed for the audit.

This require the JSS PR 972 and tomcatjss PR 73

Copy link
Contributor

@ladycfu ladycfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When SSLEngine is used IPs cannot be retrieved from the socket or stream
proxies so they are stored into the SSLEngine session.

This is an extension to the standard because the SSLEngine should be
unaware of the underlying communication but it is needed for the audit.
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
65.7% 65.7% Duplication

@fmarco76
Copy link
Member Author

The failed job in the CI is not related to this PR so the problem will be investigated separately

@fmarco76 fmarco76 merged commit 45b59b5 into dogtagpki:master Aug 29, 2023
150 of 151 checks passed
@fmarco76 fmarco76 deleted the EventACCESSMissIP branch August 30, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants