Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build RPM with Maven #4496

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Build RPM with Maven #4496

merged 1 commit into from
Jul 10, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jul 7, 2023

The RPM spec file has been modified to build Java binaries and run unit tests with Maven, then build PKI console, Javadoc, and native binaries with CMake. In the future it might be possible to build everything with Maven.

The build.sh has been modified to provide an option to skip building Java binaries. The CMake scripts have been modified to provide separate build targets for Java binaries, PKI console, Javadoc, and native binaries. The javac(), jar(), javadoc(), link(), and add_junit_test() macros have been modified to no longer be included in the default build target to provide more controls over the build process.

@edewata edewata added the WIP Work In Progress label Jul 7, 2023
@edewata
Copy link
Contributor Author

edewata commented Jul 7, 2023

It's not ready yet. There's a build issue on CentOS/RHEL.

The RPM spec file has been modified to build Java binaries and
run unit tests with Maven, then build PKI console, Javadoc, and
native binaries with CMake. In the future it might be possible
to build everything with Maven.

The build.sh has been modified to provide an option to skip
building Java binaries. The CMake scripts have been modified to
provide separate build targets for Java binaries, PKI console,
Javadoc, and native binaries. The javac(), jar(), javadoc(),
link(), and add_junit_test() macros have been modified to no
longer be included in the default build target to provide more
controls over the build process.
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@edewata edewata removed the WIP Work In Progress label Jul 7, 2023
@edewata
Copy link
Contributor Author

edewata commented Jul 7, 2023

It's working now. I had to set JAVA_HOME.

Copy link
Contributor

@ckelleyRH ckelleyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jul 10, 2023

@ckelleyRH Thanks!

@edewata edewata merged commit 7c7fdd0 into dogtagpki:master Jul 10, 2023
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants