Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in UsrGrpAdminServlet #4498

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix NPE in UsrGrpAdminServlet #4498

merged 1 commit into from
Jul 12, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jul 11, 2023

In commit 11d268f the UsrGrpAdminServlet's constructor was modified to get the CMSEngine object from the servletContext before the field was initialized which triggered a NullPointerException. To fix the problem the code in the constructor has been moved into init() so that it will run after the servletContext initialization.

https://issues.redhat.com/browse/RHEL-626

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In commit 11d268f the
UsrGrpAdminServlet's constructor was modified to get the CMSEngine
object from the servletContext before the field was initialized
which triggered a NullPointerException. To fix the problem the code
in the constructor has been moved into init() so that it will run
after the servletContext initialization.

https://issues.redhat.com/browse/RHEL-626
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@edewata
Copy link
Contributor Author

edewata commented Jul 12, 2023

@fmarco76 Thanks!

@edewata edewata merged commit 5afb3c0 into dogtagpki:master Jul 12, 2023
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants