Create temporary files to be shared between uses in /tmp #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some commands need to be executed as the pki user and not root to retain filesystem permissions. There are a few places where passwords are written to files as root to be passed into commands executed by pkiuser. If a private temporary directory is set before pkispawn is called then this method for sharing passwords between users will not work because the file will be unreadable. So force these calls to use /tmp directly instead of the private temporary directory. Fixes: dogtagpki#4475 Signed-off-by: Rob Crittenden <[email protected]>
|
This should be backported to 11.3 and 11.4. I can open those PRs as well if desired. |
|
Kudos, SonarCloud Quality Gate passed! |
ckelleyRH
approved these changes
Jul 14, 2023
Should the CI be happy on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commands need to be executed as the pki user and not root to retain filesystem permissions. There are a few places where passwords are written to files as root to be passed into commands executed by pkiuser.
If a private temporary directory is set before pkispawn is called then this method for sharing passwords between users will not work because the file will be unreadable.
So force these calls to use /tmp directly instead of the private temporary directory.
Fixes: #4475