Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Implementation-Version to Manifests via pom.xml #4507

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

ckelleyRH
Copy link
Contributor

The /getStatus endpoints in the web UI were returning a null version since the build was switched to Maven.

It is probably now possible to remove the individual manifest files but I have left them as they are for now so we can still build with cmake if we wish.

The /getStatus endpoints in the web UI were returning a null
version since the build was switched to Maven.

It is probably now possible to remove the individual manifest files
but I have left them as they are for now so we can still build with
cmake if we wish.
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
6.9% 6.9% Duplication

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckelleyRH ckelleyRH merged commit 2a407d0 into dogtagpki:master Jul 20, 2023
139 checks passed
@ckelleyRH ckelleyRH deleted the nmplementation-Version branch July 20, 2023 05:35
@ckelleyRH
Copy link
Contributor Author

Thanks @edewata !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants