Add pki-server ca-crl-* commands #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckelleyRH
approved these changes
Aug 21, 2023
Comment on lines
927
to
948
| print(' Allow Extensions: %s' % config.get('allowExtensions')) | ||
| print(' Always Update: %s' % config.get('alwaysUpdate')) | ||
| print(' Auto Update Interval: %s' % config.get('autoUpdateInterval')) | ||
| print(' CA Certs Only: %s' % config.get('caCertsOnly')) | ||
| print(' Cache Update Interval: %s' % config.get('cacheUpdateInterval')) | ||
| print(' Unexpected Exception Wait Time: %s' % config.get('unexpectedExceptionWaitTime')) | ||
| print(' Unexpected Exception Loop Max: %s' % config.get('unexpectedExceptionLoopMax')) | ||
| print(' Daily Updates: %s' % config.get('dailyUpdates')) | ||
| print(' Enable CRL Cache: %s' % config.get('enableCRLCache')) | ||
| print(' Enable CRL Updates: %s' % config.get('enableCRLUpdates')) | ||
| print(' Enable Cache Testing: %s' % config.get('enableCacheTesting')) | ||
| print(' Enable Cache Recovery: %s' % config.get('enableCacheRecovery')) | ||
| print(' Enable Daily Updates: %s' % config.get('enableDailyUpdates')) | ||
| print(' Enable Update Interval: %s' % config.get('enableUpdateInterval')) | ||
| print(' Extended Next Update: %s' % config.get('extendedNextUpdate')) | ||
| print(' Include Expired Certs: %s' % config.get('includeExpiredCerts')) | ||
| print(' Min Update Interval: %s' % config.get('minUpdateInterval')) | ||
| print(' Next Update Grace Period: %s' % config.get('nextUpdateGracePeriod')) | ||
| print(' Publish On Start: %s' % config.get('publishOnStart')) | ||
| print(' Save Memory: %s' % config.get('saveMemory')) | ||
| print(' Signing Algorithm: %s' % config.get('signingAlgorithm')) | ||
| print(' Update Schema: %s' % config.get('updateSchema')) |
There was a problem hiding this comment.
This could be tidied up a bit with a multi-line f-string, but this is minor
print(f""" Allow Extensions: {config.get('allowExtensions')}
Always Update: {config.get('alwaysUpdate')}
...
""")
There was a problem hiding this comment.
Will that preserve the 2-space indentation?
There was a problem hiding this comment.
Looks like I'll need to use textwrap.dedent() and indent(). Let me try something..
There was a problem hiding this comment.
OK, patch updated. It does look cleaner. 👍
The pki-server ca-crl-show command has been added to make it easier to inspect CRL configuration.
The pki-server ca-crl-ip-find/show commands have been added to make it easier to inspect CRL issuing point configuration.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ckelleyRH Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pki-server ca-crl-showcommand has been added to make it easier to inspect CRL configuration.The
pki-server ca-crl-ip-find/showcommands have been added to make it easier to inspect CRL issuing point configuration.https://github.com/dogtagpki/pki/wiki/PKI-Server-CA-CRL-CLI