Replace JAX-RS with servlet status code in PKIExceptions #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edewata
approved these changes
Aug 16, 2024
| public PKIException(Throwable cause) { | ||
| this(Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(), cause.getMessage(), cause); | ||
| this(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, "Internal Server Error", cause); |
There was a problem hiding this comment.
Could we include cause.getMessage() in the exception message to help troubleshooting?
There was a problem hiding this comment.
The message is printed to the end-user so it should not provide internal details and there are are logs including the messages for the majority of (if not all) cases to help troubleshooting. However, since this was the original behaviour I am reverting this message and we can evaluate later if it is OK to have.
fmarco76
force-pushed
the
DropRestEasy_Exceptions
branch
from
cf2e664
to
160d3d0
Compare
|
@edewata Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.