Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPS TPSProfileService to v2 APIs #4831

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

fmarco76
Copy link
Member

No description provided.

@fmarco76 fmarco76 requested a review from edewata August 21, 2024 10:09
Copy link

sonarcloud bot commented Aug 21, 2024

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM, just one minor comment.

}
}
try {
if ((authorizedProfiles== null) || ((authorizedProfiles != null) && !authorizedProfiles.contains(UserResource.ALL_PROFILES) && !authorizedProfiles.contains(profileID))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authorizedProfiles != null probably can be removed too like in getProfile().

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit a26cc9a into dogtagpki:master Aug 26, 2024
21 of 29 checks passed
@fmarco76 fmarco76 deleted the ProfileService_v2 branch August 26, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants