Drop ClonesConnectivyAndDataCheck from pki-healthcheck #4843
+1
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pki-healthcheck is a tool to check the status of an instance or a node in a cluster so that if it reports a problem the admin can fix it or the monitoring service can replace it with a new node. The ClonesConnectivyAndDataCheck on the other hand is a plugin that checks the connectivity from the instance to other clones. This plugin will report a problem if another clone is down even though the instance itself is fine, which would be misleading. Since it doesn't really fit the purpose of pki-healthcheck this plugin has been dropped.
|
|
@fmarco76 Thanks! I've also fixed some tests affected by this change. |
|
@edewata this change introduces a regression in our tests because we have one test that calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pki-healthcheckis a tool to check the status of an instance or a node in a cluster so that if it reports a problem the admin can fix it or the monitoring service can replace it with a new node.The
ClonesConnectivyAndDataCheckon the other hand is a plugin that checks the connectivity from the instance to other clones. This plugin will report a problem if another clone is down even though the instance itself is fine, which would be misleading. Since it doesn't really fit the purpose ofpki-healthcheckthis plugin has been dropped.Note:
pki-healthcheckfailure in themasterbranchpki-healthcheckis no longer failing, but the test is still failing due to a different reason. It will be investigated separately later.