-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pkispawn to support ACME #4848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with ACME but the code looks good. I have a comment for the configuration properties but feel free to merge and discuss later further changes.
pki_security_domain_setup=False | ||
pki_registry_enable=False | ||
|
||
# Database params: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these parameters are not included with default empty value?
All parameters start with pki_
while these starts with acme_
. Actually I think start the subsystem variable with <subsystem>_
and leave pki_
to the global section could be better but I like consistency more.
pkispawn has been modified to support installing ACME in a shared PKI server (e.g. with existing CA). New pkispawn params have been added to specify the ACME database, issuer, and realm. A sample configuration has been provided in acme.cfg. The pki_ds_setup, pki_security_domain_setup, and pki_registry_enable params in the default.cfg have been moved from [DEFAULT] into each subsystem's section so that ACME can skip DS setup, security domain setup, and registry setup by default. The templates for ACME database, issuer, and realm configs have been modified to no longer contain passwords. The passwords need to be specified during installation. Some code in acme.py has been moved into subsystem.py so that it can be reused. The basic ACME test and the test with PostgreSQL have been modified to install ACME using pkispawn.
Quality Gate passedIssues Measures |
@fmarco76 Thanks! I've fixed some pylint issues. I'll merge but feel free to continue the discussion. There's no default params for database/issuer/realm since the I was considering to use |
pkispawn
has been modified to support installing ACME in a shared PKI server (e.g. with existing CA).New
pkispawn
params have been added to specify the ACME database, issuer, and realm. A sample configuration has been provided inacme.cfg
.The
pki_ds_setup
,pki_security_domain_setup
, andpki_registry_enable
params in thedefault.cfg
have been moved from[DEFAULT]
into each subsystem's section so that ACME can skip DS setup, security domain setup, and registry setup by default.The config templates for ACME database, issuer, and realm have been modified to no longer contain passwords. The passwords will need to be specified during installation.
Some code in
acme.py
has been moved intosubsystem.py
so that it can be reused.The basic ACME test and the test with PostgreSQL have been modified to install ACME using
pkispawn
.