Address Test Port final TMS fixes for rhel7 to master branch, phase 2… #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarco76
reviewed
Nov 5, 2024
|
|
||
| if (tempKey == null) { | ||
| return createNoContentResponse(); | ||
| } | ||
|
|
||
| logger.debug("TPSConnectorService.createSharedSecret. about to export shared secret : " + nickname + " certs.length " + certs.length); | ||
| logger.debug("TPSConnectorService.createSharedSecert cert: " + certs[certs.length -1]); | ||
| List<byte[]> listWrappedKeys = CryptoUtil.exportSharedSecret(nickname, certs[certs.length -1], tempKey, getUseOAEPKeyWrap()); | ||
| List<byte[]> listWrappedKeys = CryptoUtil.exportSharedSecretWithAES(nickname, certs[certs.length -1], tempKey,getUseOAEPKeyWrap()); | ||
| logger.debug("TPSConnectorService.createSharedSecret. done exporting shared secret : " + nickname); |
There was a problem hiding this comment.
I think the same fix should be applied to TPSConnectorProcessor.java because in the future we should move to rest v2.
There was a problem hiding this comment.
Concern has been addressed in recent push.
jmagne
force-pushed
the
master-latest-tms
branch
from
040980b
to
7eb6cb9
Compare
|
jmagne
force-pushed
the
master-latest-tms
branch
from
7eb6cb9
to
24978ad
Compare
…, RHCS-5403 This checkin coincides with the final sub task of porting the rhel7 tms to the master branch. Once this code makes it to the testing phase, every feature present in the lastest version of the rhel7 tms system should be present in any releases taken from the master branch. Add some more TPS CS.cfg comments for newer features. Fix tps docker test to include the cfg variable needed to allow tpsclient enrollments to complete. Update call to CryptoUtil.exportSharedSecretWithAES in TPSConnectorProcessor.java to reflect change to TPSConnectorService.java. Addresss github code security concerns. Change-Id: I7c98ddeffafd912debb908c9efc7a6bb591807ee
jmagne
force-pushed
the
master-latest-tms
branch
from
24978ad
to
4796ced
Compare
|
Addressed the main test failures that I could control. About to merge. |
|
Fixed TPS test issue and determined that all the other test failures are known issues. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, RHCS-5403
This checkin coincides with the final sub task of porting the rhel7 tms to the master branch.
Once this code makes it to the testing phase, every feature present in the lastest version of the rhel7 tms system should be present in any releases taken from the master branch.
Add some more TPS CS.cfg comments for newer features.
Change-Id: I7c98ddeffafd912debb908c9efc7a6bb591807ee