Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Enable strict float emulation by default on new Nvidia drivers #4389

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

K0bin
Copy link
Collaborator

@K0bin K0bin commented Oct 22, 2024

Not yet tested.

@Blisto91
Copy link
Contributor

Since my GPU is in the higher end it is a bit hard to get bound in any of the games we already default to Strict where it doesn't also fluctuate, but using the classic test Witcher 2 it is looking fine.

Screenshots

d3d9.floatEmulation = True with 560.35.03
witcher2true560

d3d9.floatEmulation = Strict with 560.35.03
witcher2strict560

d3d9.floatEmulation = Strict with 565.57.01
witcher2strict565

@Blisto91
Copy link
Contributor

Note that this will introduce #4319 on Nvidia

@doitsujin
Copy link
Owner

Why do we not already have an app profile for TR Legend if it's literally broken right now?

@Blisto91
Copy link
Contributor

Blisto91 commented Oct 24, 2024

It was just recently discovered that the issue shows when floatEmulation is set to Strict and it haven't been looked at why yet I believe.
I would be careful with just making a config setting it to True without some testing as the game seems sensitive to it in general. The reporter says that disabling invariantPosition also fixes it, but that doesn't seem to be the case on Nvidia from my own testing. Game also had a similar issue in another place in the past before longMad was enabled.

@doitsujin
Copy link
Owner

doitsujin commented Oct 24, 2024

In any case I don't see a good reason to stall this PR based on an issue that already affects other GPUs, it needs to be looked at separately.

@K0bin K0bin marked this pull request as ready for review November 3, 2024 12:51
@doitsujin doitsujin merged commit 62970d2 into doitsujin:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants