DXSO: Fix various shader instructions #4442
Merged
+29
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
d3d9-lerp-mad
branch
2 times, most recently
from
e02d65f
to
e7b60a5
Compare
doitsujin
changed the title
|
Tested on Nvidia, fixes #4319. |
qinlili23333
approved these changes
Nov 11, 2024
Games expect this to be equivalent to add -> mad, but since we changed mad to emit mul + add, this is no longer the case. Also remove OpFMix path.
Potentially avoids vertex shader bugs if a game expects dot product and a chain of mad instructions to return the same result.
doitsujin
force-pushed
the
d3d9-lerp-mad
branch
from
63d0e48
to
5463dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4319, Supersedes #4439.