Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module password #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Module password #10

wants to merge 3 commits into from

Conversation

lvolcov
Copy link
Contributor

@lvolcov lvolcov commented Dec 30, 2020

No description provided.

jampow
jampow requested changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jampow jampow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O único item que vejo como obrigatório é a documentação do método, os outros estão abertos à discussão.

@jampow jampow added the enhancement New feature or request label Jan 2, 2021
@jampow
Copy link
Contributor

jampow commented Jan 3, 2021

@all-contributors please add @lvolcov for code, documentation, tests

@allcontributors allcontributors bot mentioned this pull request Jan 3, 2021
Merged
@allcontributors
Copy link
Contributor

@jampow

I've put up a pull request to add @lvolcov! 🎉

@jampow jampow added this to the Versão 1.0.0 milestone Jan 3, 2021
jampow
jampow previously approved these changes Feb 8, 2021
View reviewed changes
@jampow jampow changed the base branch from master to main April 26, 2022 04:37
@jampow jampow dismissed their stale review April 26, 2022 04:37

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jampow jampow jampow left review comments

@gledsoncr gledsoncr Awaiting requested review from gledsoncr gledsoncr is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Versão 1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lvolcov @jampow @gledsoncr