Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache tutorial test results #356

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vansimke
Copy link
Contributor

Resolves #354

Currently, when the site's master branch is updated, a Travis build installs the dependencies and runs the tests for each of the finished tutorial demos. This causes deployment times to be excessively long and ties up CI resources.

This change addresses this issue by introducing a precommit task to the grunt configuration that allows all of the demos to be inspected for changes and runs the tests if they have been. Upon successful completion, a hash is stored containing the signature of the demo code. This is then checked by Travis and, if the calculated hash matches the stored one, the tests are not re-run.

In addition to creating the new grunt task, this change also updates the .travis.yml script to remove that parts that were triggering the tests previously. This has been replaced by the addition of a verifyTutorials:ci task in the grunt configuration. This change makes it easier to determine if a demo needs to be rebuilt by reusing code from the precommit task to calculate the demo's hash and comparing it to the one that was stored.

@dylans dylans added this to the 2017.12 milestone Dec 22, 2017
@dylans dylans modified the milestones: 2017.12, 2018.01 Jan 17, 2018
@dylans dylans modified the milestones: 2018.01, 2018.02 Feb 2, 2018
@dylans dylans modified the milestones: 2018.02, 2018.03 Feb 28, 2018
@dylans
Copy link
Member

dylans commented Mar 19, 2018

This needs to be rebased, tested, and hopefully landed to speed up our PR review process for tutorials.

@maier49 maier49 requested a review from itorrey April 6, 2018 15:37
@dylans dylans modified the milestones: 2018.03, 2018.04 Apr 11, 2018
@dylans dylans modified the milestones: 2018.04, 2018.05 May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants