Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set AppVeyor build version #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Rondom
Copy link
Contributor

@Rondom Rondom commented Mar 29, 2017

This sets the AppVeyor build version according to the version we get from the repository, i.e. 1.0.2-590 becomes ``1.0.2.1590` (like the installer and DLL-versions).

@Rondom
Copy link
Contributor Author

Rondom commented Mar 29, 2017

This produces broken links like
https://ci.appveyor.com/project/Maxhy/dokany/build/1.0.2-163 while the build is running. Only when the build is finished the link is updated on the GitHub side to for example
https://ci.appveyor.com/project/Maxhy/dokany/build/1.0.2.1163

So, don't merge this. :-(

Alternative approaches

  1. Keep version in appveyor.yml in sync with "our version" (i.e. format). In case of mismatch update (GitHub links will be broken, during build)
  2. Keep version in appveyor.yml in sync with "our version" (i.e. format). In case of mismatch warn
  3. Keep version in appveyor.yml in sync with "our version" (i.e. format). In case of mismatch fail build
  4. Leave everything as it is

@Liryna
Copy link
Member

Liryna commented Mar 29, 2017

Hi @Rondom ,

Github broken link during the build is alright I think. I personally always wait at the end if everything passed or otherwise look in the history current running build.
But maybe we can ask appveyor why Update-AppveyorBuild does not directly update in live the link ?

@Rondom
Copy link
Contributor Author

Rondom commented Aug 12, 2017

But maybe we can ask appveyor why Update-AppveyorBuild does not directly update in live the link ?

appveyor/ci#1074

@Rondom
Copy link
Contributor Author

Rondom commented Feb 4, 2018

@timofonic Not sure what your intention is in inquiring about this issue, given that it does not really affect users in any way. :-)

The long story is that I started developing a cleaner approach for the version-handling, but did not finish it. https://github.com/Rondom/dokany/tree/no_hardcode_version

Do you want to help?

@Rondom Rondom force-pushed the patch-2 branch 3 times, most recently from 9407e22 to d5c906e Compare November 4, 2018 16:12
@Liryna
Copy link
Member

Liryna commented Sep 12, 2019

Hi @Rondom

I just saw you force pushed at the beginning of the year, what the state of this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants