-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Set AppVeyor build version #485
base: master
Are you sure you want to change the base?
Conversation
This produces broken links like So, don't merge this. :-( Alternative approaches
|
Hi @Rondom , Github broken link during the build is alright I think. I personally always wait at the end if everything passed or otherwise look in the history current running build. |
|
@timofonic Not sure what your intention is in inquiring about this issue, given that it does not really affect users in any way. :-) The long story is that I started developing a cleaner approach for the version-handling, but did not finish it. https://github.com/Rondom/dokany/tree/no_hardcode_version Do you want to help? |
9407e22
to
d5c906e
Compare
Hi @Rondom I just saw you force pushed at the beginning of the year, what the state of this PR ? |
f03d51a
to
a1a557b
Compare
b8ac392
to
1ffacd4
Compare
This sets the AppVeyor build version according to the version we get from the repository, i.e.
1.0.2-590
becomes ``1.0.2.1590` (like the installer and DLL-versions).