Support Nix environment #1335
Merged
Support Nix environment #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ribbanya
requested changes
Feb 27, 2024
There was a problem hiding this comment.
See #1335 (review) and let me know what you think. I'll handle refactoring the Python scripts if you can refactor the Nix scripts. The main thing would be implementing a nix function to invoke download_tool.py.
ribbanya
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
main.dolin the nix sandbox usingnix-build.Enter development environment using
nix-shell. Unlike the makefile build, the configure.py script doesn't pick up environment variables, so you have to manually specify some locations when configuring. You cancat $configurePhaseto see what you need to specify.