-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itcoin
#1380
Merged
Merged
itcoin
#1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribbanya
requested changes
Mar 15, 2024
ribbanya
reviewed
Mar 15, 2024
ribbanya
reviewed
Mar 15, 2024
Co-authored-by: Robin Avery <[email protected]>
ribbanya
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes
Ground_801C58E0
due to it returningit_802F2094
struct Item
due to the accesses init_802F1F48
it_802F1630
andit_802F1CE0
seem to be non-matching for the same reasonit_802F1910
is so close to matching, it's just the condition within the firstif
statementIf any matching changes are obvious, please lmk and I'll make them. Otherwise, I'll mark this for review.