Match mnCharSel_803F0A48 and mnCharSel_803F0DFC #1388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is my first time contributing to the decomp. So please don't hesitate to let me know if I've done anything "out of protocol" :)
Justification
mnCharSel_803F0A48 is primarily concerned with icon and mode data while mnCharSel_803F0DFC is concerned with the doors at the bottom of the screen.
Both appear to be pieces of data heavily used by other functions in mncharsel, so matching this should accelerate the decompilation of the CSS.
These data structures are also well known and propagated among various mods, Gecko codes, tools, etc.
Implementation
I created two data structs for each of the memory structures with as much info as I could find then filled in the defaults into a variable in .data (where objdiff says they're located).
Testing