Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match mnCharSel_803F0A48 and mnCharSel_803F0DFC #1388

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

blueOkiris
Copy link
Contributor

NOTE: This is my first time contributing to the decomp. So please don't hesitate to let me know if I've done anything "out of protocol" :)

Justification

mnCharSel_803F0A48 is primarily concerned with icon and mode data while mnCharSel_803F0DFC is concerned with the doors at the bottom of the screen.

Both appear to be pieces of data heavily used by other functions in mncharsel, so matching this should accelerate the decompilation of the CSS.

These data structures are also well known and propagated among various mods, Gecko codes, tools, etc.

Implementation

I created two data structs for each of the memory structures with as much info as I could find then filled in the defaults into a variable in .data (where objdiff says they're located).

Testing

  1. Objdiff shows 100% match for each and proper sizing
  2. Through the use of static write mods, I have verified the different mappings to characters to ensure that the names used are accurate as well as offsets.

Also for following data at 0x803F0DFC

Signed-off-by: Dylan Turner <[email protected]>
@blueOkiris blueOkiris force-pushed the mnCharSel_803F0A48 branch from cafaa29 to 8ecdfec Compare June 11, 2024 03:13
@blueOkiris
Copy link
Contributor Author

Changes: I noticed I failed the first formatting check, so I fixed the formatting and redid the commits

@ribbanya
Copy link
Collaborator

Thank you!

@ribbanya ribbanya merged commit a60e81d into doldecomp:master Jun 11, 2024
8 checks passed
@blueOkiris blueOkiris deleted the mnCharSel_803F0A48 branch June 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants