Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match some ftCommon functions #1397

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Match some ftCommon functions #1397

merged 4 commits into from
Jul 15, 2024

Conversation

thefoxcam
Copy link
Collaborator

Full matches:
src/melee/ft/chara/ftCommon/ftCo_PassiveWall.c
src/melee/ft/chara/ftCommon/ftCo_0C35.c

Improved scores:
src/melee/ft/chara/ftCommon/ftCo_AirCatch.c

Notes:
The weird loop in ftCo_800C3A14 is actually a struct copy of CollData. However our current size of CollData is four bytes too large for it to match, seemingly confirming that CollData's last member ecb_lock is not a part of it.

@ribbanya ribbanya enabled auto-merge (squash) July 15, 2024 01:59
@ribbanya ribbanya merged commit c7f52f4 into doldecomp:master Jul 15, 2024
8 checks passed
@thefoxcam thefoxcam deleted the misc branch July 31, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants