Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Display more user-friendly names in the mapping window device list. #13176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordan-woyak
Copy link
Member

@jordan-woyak jordan-woyak commented Nov 6, 2024

Before:
image

After:
image

I think the SDL/0/DualSense text is too weird and technical looking for a typical user.

The information is now reversed with device name first and backend name last.
Device index has one added for 1-based numbering.

This is only a UI change, config names remain unchanged.

The advanced window also remains unchanged.
This creates a 0-based/1-based numbering discrepancy, but since the config names can end up in the input expression I think it's appropriate to have that match the device list shown here for "advanced" users.

Open to opinions on the situation.

@iwubcode
Copy link
Contributor

iwubcode commented Nov 7, 2024

This is only a UI change, config names remain unchanged.

This makes it complicated for users who need to specify the name for configuration. If we do this, it would be nice to have a way to copy the internal path. Specifically, I'm thinking of dynamic input textures where users often need to notify us of what their device path is so we can add it the the pack.

I'm curious, has anyone actually complained about this? My biased take is that it's not more readable, just different, but maybe I'm too used to the old way. If we are committed to this, it'd be nice if the list was at least sorted by the display name.

@jordan-woyak
Copy link
Member Author

This makes it complicated for users who need to specify the name for configuration. If we do this, it would be nice to have a way to copy the internal path. Specifically, I'm thinking of dynamic input textures where users often need to notify us of what their device path is so we can add it the the pack.

I don't know if this change makes it really any more complicated for that task. I don't think users are manually typing out the text they see in the dropdown list? They can still copy-paste from their ini-file or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants