Add a regression test for #891 - Unimplemented #smallImageExtent

The RegEdit sample uses a ListView, so a package closure test on it picks up the unimplemented #smallImageExtent message that was the subject of the bug.
dolphinsmalltalk · May 12, 2020 · c0e8252 · c0e8252
1 parent eb2be69
commit c0e8252
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 5 deletions.
diff --git a/Core/Object Arts/Dolphin/ActiveX/Shell/Windows Shell.pax b/Core/Object Arts/Dolphin/ActiveX/Shell/Windows Shell.pax
@@ -92,7 +92,7 @@ unregisterShellMessages
 	self unregisterMessageMappings: {WM_DROPFILES}! !
 !View class categoriesFor: #registerShellMessages!development!initializing!public! !
 !View class categoriesFor: #shellMessageMappings!constants!must not strip!private! !
-!View class categoriesFor: #unregisterShellMessages!public! !
+!View class categoriesFor: #unregisterShellMessages!class hierarchy-removing!public! !
 
 "End of package definition"!
 
diff --git a/Core/Object Arts/Dolphin/Lagoon/Lagoon Tests.pax b/Core/Object Arts/Dolphin/Lagoon/Lagoon Tests.pax
@@ -24,7 +24,8 @@ package setPrerequisites: #(
 	'..\MVP\Icons\Internal Bitmaps and Icons'
 	'Lagoon Image Stripper'
 	'..\..\Samples\MVP\Notepad\Notepad'
-	'..\..\..\Contributions\Refactory\Refactoring Browser\Environments\RBEnvironments').
+	'..\..\..\Contributions\Refactory\Refactoring Browser\Environments\RBEnvironments'
+	'..\..\Samples\MVP\RegEdit\RegEdit').
 
 package!
 

diff --git a/Core/Object Arts/Dolphin/Lagoon/PackageClosureTests.cls b/Core/Object Arts/Dolphin/Lagoon/PackageClosureTests.cls
@@ -102,6 +102,13 @@ testNotepad
 	self verifyPackageClosure: (self environmentForAppDeployment: {Notepad owningPackage})
 		missing: self simpleGuiAppUnimplementedMessages!
 
+testRegEdit
+	"Regedit uses List and Tree views"
+
+	| env |
+	env := self environmentForAppDeployment: {RegEdit owningPackage}.
+	self verifyPackageClosure: env missing: self simpleGuiAppUnimplementedMessages!
+
 testSystemPackage
 	| aPackage |
 	aPackage := Object owningPackage.
@@ -127,6 +134,7 @@ verifyPackageClosure: aBrowserEnvironment missing: aCollectionOfSymbols
 !PackageClosureTests categoriesFor: #testEtchASketch!public!unit tests! !
 !PackageClosureTests categoriesFor: #testHelloWorld!public!unit tests! !
 !PackageClosureTests categoriesFor: #testNotepad!public!unit tests! !
+!PackageClosureTests categoriesFor: #testRegEdit!public!unit tests! !
 !PackageClosureTests categoriesFor: #testSystemPackage!public!unit tests! !
 !PackageClosureTests categoriesFor: #verifyPackageClosure:missing:!helpers!private! !
 
diff --git a/Core/Object Arts/Dolphin/Registry/RegKey.cls b/Core/Object Arts/Dolphin/Registry/RegKey.cls
@@ -113,7 +113,7 @@ subValues
 	! !
 !RegKey categoriesFor: #at:ifAbsent:!accessing!public! !
 !RegKey categoriesFor: #at:put:!accessing!public! !
-!RegKey categoriesFor: #fileOutOn:!public!source filing! !
+!RegKey categoriesFor: #fileOutOn:!public!storing! !
 !RegKey categoriesFor: #includesKey:!public!searching! !
 !RegKey categoriesFor: #keysAndValuesDo:!enumerating!public! !
 !RegKey categoriesFor: #keysDo:!enumerating!public! !

diff --git a/Core/Object Arts/Dolphin/Registry/RegKeyAbstract.cls b/Core/Object Arts/Dolphin/Registry/RegKeyAbstract.cls
@@ -763,7 +763,7 @@ valueFromObject: value
 !RegKeyAbstract categoriesFor: #decodeMultiSz:size:!helpers!private! !
 !RegKeyAbstract categoriesFor: #displayOn:!displaying!public! !
 !RegKeyAbstract categoriesFor: #do:!enumerating!public! !
-!RegKeyAbstract categoriesFor: #fileOutOn:!public!source filing! !
+!RegKeyAbstract categoriesFor: #fileOutOn:!public!storing! !
 !RegKeyAbstract categoriesFor: #free!public!realizing/unrealizing! !
 !RegKeyAbstract categoriesFor: #fullPath!accessing!public! !
 !RegKeyAbstract categoriesFor: #handle!accessing!public! !

diff --git a/Core/Object Arts/Dolphin/Registry/RegKeyValues.cls b/Core/Object Arts/Dolphin/Registry/RegKeyValues.cls
@@ -139,7 +139,7 @@ subValues
 !RegKeyValues categoriesFor: #at:ifAbsent:!accessing!public! !
 !RegKeyValues categoriesFor: #at:put:!accessing!public! !
 !RegKeyValues categoriesFor: #changeKey:to:!accessing!private! !
-!RegKeyValues categoriesFor: #fileOutOn:!public!source filing! !
+!RegKeyValues categoriesFor: #fileOutOn:!public!storing! !
 !RegKeyValues categoriesFor: #includesKey:!public!searching! !
 !RegKeyValues categoriesFor: #keysAndValuesDo:!enumerating!public! !
 !RegKeyValues categoriesFor: #keysDo:!enumerating!public! !