-
Notifications
You must be signed in to change notification settings - Fork 225
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Add an error message instead of raising an exception when an aggregate report timespan is greater than 24 hours
- Loading branch information
1 parent
0eaba07
commit 1655b84
Showing
2 changed files
with
10 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1655b84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
why has it been changed from Exception to an Error Message?
Because of the Exception, the invalid report has not been imported to ElasticSearch, which was the desired outcome. Now because it's only an Error Message it's imported into ElasticSearch again, and the graphs are broken again. If those invalid reports get imported into Elasticsearch, and you search for the last 14 days, you also get data points from 20 or 30 or 40 days ago, which makes the graph look wrong/broken. Reports with invalid date ranges should not be imported to ElasticSearch.