-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SMTP TLS reports #453
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 58.42% 54.29% -4.13%
==========================================
Files 11 11
Lines 1347 1501 +154
==========================================
+ Hits 787 815 +28
- Misses 560 686 +126 ☔ View full report in Codecov by Sentry. |
Ok. I think initial SMTP TLS report support is done, including JSON, CSV, Elasticsearch, and Splunk output, but I haven't done much testing yet Other steps that are needed:
|
I was able to reuse existing code to create SMTP TLS report output support for Kafka, S3, Log Analytics, and Syslog. I have not tested any of these and testing would be appreciated. |
@seanthegeek I'll see if I can test it for Log Analytics. But I first need an SMTP TLS report. |
Hi @seanthegeek I haven't worked in a Kafka environment/dealing with DMARC since 2020. I can reach out to some old coworkers though and see if they can help out. |
Hi @seanthegeek it's been a while since I've looked at this but the changes in s3.py look good to me 👍 |
As far as I can tell the syslog looks ok, I'm not able to test though. |
@seanthegeek Created a Pull request #459 with some fixes and documentation. |
I have also tested the application and it works now. |
* Fix Log analytics & Fix save_smtp_tls bug * Updated documentation
…dashboard" This reverts commit 5716a45.
- Add support for SMTP TLS reports (PR #453 closes issue #71) - Do not replace content in forensic samples (fix #403) - Pin `msgraph-core` dependency at version `0.2.2` until Microsoft provides better documentation (PR #466 Close [#464](#464)) - Properly handle base64-encoded email attachments (PR #453) - Do not crash when attempting to parse invalid email content (PR #453) - Ignore errors when parsing text-based forensic reports (PR #460) - Add email date to email processing debug logs (PR #462) - Set default batch size to 10 to match the documentation (PR #465) - Properly handle none values (PR #468) - Add Gmail pagination (PR #469) - Use the correct `msgraph` scope (PR #471)
This is a draft PR. I need some help working on it.