Fix if base_domain is None before get_service_from_reverse_dns_base_d… #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omain call - Added if statement for base_domain before getting get_service_from_reverse_dns_base_domain(). If base_domain is None, get_service_from_reverse_dns_base_domain() will fail the report. - Added .xml test file
added .xml test sample report where base_domain return none
|
This PR fixes an issue, if base_domain has resolved to 'None' before calling the function get_service_from_reverse_dns_base_domain() |
seanthegeek
added a commit
that referenced
this pull request
May 22, 2024
- Fix for deadlock with large report (#508) - Build: move to kafka-python-ng (#510) - Fix new config variables previously not propagated in the code (#524) - Fixes for kafka integration (#522) - Fix if base_domain is None before get_service_from_reverse_dns_base_domain (#514) - Update base_reverse_dns_map.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : If base_domain is None, get_service_from_reverse_dns_base_domain() will fail.