Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ObjectMember interface for Sphinx autoenum members rather than tu… #78

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Use ObjectMember interface for Sphinx autoenum members rather than tu… #78

merged 3 commits into from
Aug 24, 2023

Conversation

adamtheturtle
Copy link
Contributor

…ples

Without this, autoenum is broken for Sphinx 7.2.0.

@auto-assign auto-assign bot requested a review from domdfcoding August 22, 2023 00:11
@repo-helper repo-helper bot added failure: mypy The mypy check is failing. failure: docs The docs check is failing. labels Aug 22, 2023
@adamtheturtle adamtheturtle force-pushed the sphinx-7.2.0-objectmember branch 2 times, most recently from a03f03f to ff89190 Compare August 22, 2023 00:17
@repo-helper repo-helper bot added failure: Linux The Linux tests are failing. failure: Windows The Windows tests are failing. and removed failure: docs The docs check is failing. labels Aug 22, 2023
@adamtheturtle
Copy link
Contributor Author

@domdfcoding If I fix the tests / linting does this look like something you would merge / release?

@domdfcoding
Copy link
Owner

From the failures it looks like ObjectMember doesn't exist in Sphinx 3.2 and 3.3 (added in 3.4 presumably). I'm not sure it's worth the effort to do a special case for those two (old) versions so I will remove them from the CI matrix.

@domdfcoding
Copy link
Owner

I've dropped Sphinx 3.2 and 3.3 from master and rebased

@repo-helper repo-helper bot removed failure: Linux The Linux tests are failing. failure: Windows The Windows tests are failing. labels Aug 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 88.063%. remained the same when pulling 5cd08e2 on adamtheturtle:sphinx-7.2.0-objectmember into 5e67525 on domdfcoding:master.

@adamtheturtle
Copy link
Contributor Author

Thank you @domdfcoding . I made a change to satisfy mypy and I believe that the 3.12 failures are also happening in master and so they are not relevant and should not block the build passing overall.

@domdfcoding domdfcoding enabled auto-merge (squash) August 24, 2023 08:05
@repo-helper repo-helper bot added 🤖 automerge Auto merge is enabled for this pull request. and removed failure: mypy The mypy check is failing. labels Aug 24, 2023
@domdfcoding domdfcoding merged commit 6d33ec9 into domdfcoding:master Aug 24, 2023
36 of 39 checks passed
@adamtheturtle adamtheturtle deleted the sphinx-7.2.0-objectmember branch August 24, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domdfcoding domdfcoding domdfcoding approved these changes

Assignees

@domdfcoding domdfcoding

Labels
🤖 automerge Auto merge is enabled for this pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamtheturtle @domdfcoding @coveralls