Skip to content

Add public clients option to ROPC. Closes #21. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

domenic
Copy link
Owner

@domenic domenic commented Apr 28, 2014

See also #20.

@ebymatthew, please review and let me know if this works for you. I don't call validateClient this way, which seems better, and I avoid having a boolean flag that affects the hook behavior.

The readme and the integration test/example server are probably the most relevant things to review.

If this meets your use case I'll push out a 4.1.0 with it shortly.

@ebymatthew
Copy link

@domenic this is great! This meets my use case... I only intend to use public clients. The readme does a good job of explaining how to configure for public clients.

Looking through the test cases, I see that when configured for public clients it will return a token for requests that include an authentication header without validating the client credentials. That seems to violate some requirements in the ROPC section (http://tools.ietf.org/html/rfc6749#section-4.3.2) says:

The authorization server MUST:
o require client authentication for confidential clients or for any
client that was issued client credentials (or with other
authentication requirements),
o authenticate the client if client authentication is included, and ...

This doesn't affect my use case, so I'll let you decide what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants