Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cucu tags command #549

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add new cucu tags command #549

wants to merge 2 commits into from

Conversation

ddl-ebrown
Copy link

@ddl-ebrown ddl-ebrown commented Mar 4, 2025

  • Parses all of the available tags through the given features directory
    and emits them in table format

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: https://dominodatalab.atlassian.net/browse/

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

 - Parses all of the available tags through the given features directory
   and emits them in table format
"""
init_global_hook_variables()

tags = _find_unique_tags(root_dir=filepath, pattern="*.feature", string_capture="^\(@[\w-]+\)")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regex is too naive to be correct

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to just recursively parse with the actual code in the the behave library - i.e. https://github.com/behave/behave/blob/main/behave/parser.py#L829

@ddl-ebrown
Copy link
Author

@ddl-bcolby / @CCedricYoung is this something the team would entertain? I think it should be a pretty quick / useful addition

@ddl-cedricyoung ddl-cedricyoung self-requested a review March 4, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant