Switch to wagslane RabbitMQ client #21
Conversation
dmcwhorter-ddl
requested review from
ddl-kartik-mathur,
fernandoacorreia and
jradchenko
| rabbitmq.WithConsumerOptionsQueueNoDeclare, | ||
| ) | ||
| if err != nil { | ||
| c.log.Error(err, "error creating publisher") |
There was a problem hiding this comment.
nit: error creating consumer
| ) | ||
| if err != nil { | ||
| c.log.Error(err, "error creating publisher") | ||
| return nil, fmt.Errorf("error '%w' creating publisher", err) |
| if publishMandatory { | ||
| options = append(options, rabbitmq.WithPublishOptionsMandatory) | ||
| } | ||
| if publishImmediate { |
There was a problem hiding this comment.
yeah, just left the option to change this constant later
| log logr.Logger | ||
| } | ||
|
|
||
| func createRabbitMQConnection(brokerUrl string, log logr.Logger) (ConnectionWrapper, error) { |
There was a problem hiding this comment.
I presume this accepts multiple hosts in brokerUrl?
There was a problem hiding this comment.
if a host goes down will this seamlessly connect to another host?
There was a problem hiding this comment.
i do not think it accepts multiple hosts. But i will test the failover to another host via DNS resolution/service health
There was a problem hiding this comment.
how does this client support auto reconnect?
There was a problem hiding this comment.
the consumer/publisher themselves use a connection from the wagslane client that reconnects if it disconnects
dmcwhorter-ddl
force-pushed
the
rabbitmq_wagslane_client
branch
from
7eb2515 to
305ec27
Compare
Still have some testing to do, but this is compiling, has unit tests that pass, and has worked in simple ad-hoc tests.
wagslane golang RabbitMQ client