Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VULN-1917 Upgrade golang.org/x/text and golang.org/x/net #40

Merged
merged 3 commits into from
Oct 5, 2023
Merged

VULN-1917 Upgrade golang.org/x/text and golang.org/x/net #40

merged 3 commits into from
Oct 5, 2023

Conversation

pocheung1
Copy link

@pocheung1 pocheung1 commented Oct 3, 2023 •
edited
Loading

What this PR does / why we need it:

Fix vulnerabilities:

Which issue(s) this PR fixes:

VULN-1917
VULN-1948

What is the solution:

Upgrade golang.org/x/text and golang.org/x/net to latest version

operator

  • cd …/seldon-core/operator
  • vi go.mod
    • golang.org/x/text v0.13.0
    • golang.org/x/net v0.15.0
  • go mod tidy -compat=1.17

executor

  • cd …/seldon-core/executor
  • vi go.mod
    • golang.org/x/text v0.13.0
    • golang.org/x/net v0.15.0
  • make copy_operator
  • go mod tidy -compat=1.17

CI tests

  • Fix basic models test

Testing:

  • Confirmed that active CVEs no longer show up in security scans of new seldon core operator/executor images
  • Smoke tested async model api on dev-v2 with new seldon core operator/executor images

@pocheung1 pocheung1 force-pushed the po.VULN-1917.golang-x-text branch from 4c0f7db to 9fc536f Compare October 3, 2023 23:17
@pocheung1 pocheung1 force-pushed the po.VULN-1917.golang-x-text branch from b2fbec6 to 44b6d3c Compare October 4, 2023 22:04
@pocheung1 pocheung1 changed the title VULN-1917 Upgrade golang.org/x/text to v0.3.8 VULN-1917 Upgrade golang.org/x/text and golang.org/x/net Oct 5, 2023
@pocheung1 pocheung1 force-pushed the po.VULN-1917.golang-x-text branch from 70dcfda to b1e1e39 Compare October 5, 2023 19:18
@pocheung1 pocheung1 marked this pull request as ready for review October 5, 2023 19:56
@pocheung1 pocheung1 requested a review from a team as a code owner October 5, 2023 19:56
@pocheung1 pocheung1 merged commit 4671b69 into rabbitmq Oct 5, 2023
18 of 48 checks passed
@pocheung1 pocheung1 deleted the po.VULN-1917.golang-x-text branch October 5, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcwhorter-ddl dmcwhorter-ddl dmcwhorter-ddl approved these changes

@fernandoacorreia fernandoacorreia fernandoacorreia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pocheung1 @fernandoacorreia @dmcwhorter-ddl