Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a custom for user defined repositories #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

palikar
Copy link
Contributor

@palikar palikar commented Nov 12, 2018

Implementation of the suggestion in #127. Now there is a custom where
the user can specify for the presence of which files should be considered
as a directory of a repository.

Implementation of the suggestion in domtronn#127. Now there is a custom where
the user can specify for the presence of which files should be considered
as a directory of a repository.
@@ -526,6 +543,12 @@
;; Functions Start
;; ====================

(defun* all-the-icons-is-repo (path)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(defun* all-the-icons-is-repo (path)
(defun all-the-icons-is-repo (path)

@@ -526,6 +543,12 @@
;; Functions Start
;; ====================

(defun* all-the-icons-is-repo (path)
"Check if PATH is a repository."
(dolist (repo all-the-icons-mode-repositories)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emacs already has a vc-mode built-in that comes with a custom called vc-directory-exclusion-list, can you try reusing it in your all-the-icons-is-repo, how about this:

Suggested change
(dolist (repo all-the-icons-mode-repositories)
(dolist (repo vc-directory-exclusion-list)

Don't forget to load this variable somewhere in your file as well.

@wyuenho
Copy link
Collaborator

wyuenho commented Jan 6, 2021

@palikar are you still working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants