Skip to content

Commit

Permalink
Merge pull request FRRouting#14877 from k-v1/ubuntu-docker-fix-typos
Browse files Browse the repository at this point in the history
docker: fix typos in docs for ubuntu20-ci and ubuntu22-ci
  • Loading branch information
ton31337 authored Nov 27, 2023
2 parents 0dc7704 + da694b2 commit 54134b4
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
10 changes: 5 additions & 5 deletions doc/developer/building-docker.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ source-built FRR on the following base platforms:

The following platform images are used to support Travis CI and can also
be used to reproduce topotest failures when the docker host is Ubuntu
(tested on 18.04 and 20.04):
(tested on 20.04 and 22.04):

* Ubuntu 20.04
* Ubuntu 22.04
Expand Down Expand Up @@ -139,12 +139,12 @@ Build image (from project root directory)::

Running Full Topotest::

docker run --init -it --privileged --name frr -v /lib/modules:/lib/modules \
docker run --init -it --privileged --name frr-ubuntu20 -v /lib/modules:/lib/modules \
frr-ubuntu20:latest bash -c 'cd ~/frr/tests/topotests ; sudo pytest -nauto --dist=loadfile'

Extract results from the above run into `run-results` dir and analyze::

tests/topotest/analyze.py -C frr -Ar run-results
tests/topotests/analyze.py -C frr-ubuntu20 -Ar run-results

Start the container::

Expand Down Expand Up @@ -176,12 +176,12 @@ Build image (from project root directory)::

Running Full Topotest::

docker run --init -it --privileged --name frr -v /lib/modules:/lib/modules \
docker run --init -it --privileged --name frr-ubuntu22 -v /lib/modules:/lib/modules \
frr-ubuntu22:latest bash -c 'cd ~/frr/tests/topotests ; sudo pytest -nauto --dist=loadfile'

Extract results from the above run into `run-results` dir and analyze::

tests/topotest/analyze.py -C frr -Ar run-results
tests/topotests/analyze.py -C frr-ubuntu22 -Ar run-results

Start the container::

Expand Down
8 changes: 4 additions & 4 deletions docker/ubuntu20-ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ docker build -t frr-ubuntu20:latest --build-arg=UBUNTU_VERSION=20.04 -f docker/u
# Running Full Topotest

```
docker run --init -it --privileged --name frr -v /lib/modules:/lib/modules frr-ubuntu22:latest bash -c 'cd ~/frr/tests/topotests ; sudo pytest -nauto --dist=loadfile'
docker run --init -it --privileged --name frr-ubuntu20 -v /lib/modules:/lib/modules frr-ubuntu20:latest bash -c 'cd ~/frr/tests/topotests ; sudo pytest -nauto --dist=loadfile'
```

# Extract results from the above run into `run-results` dir and analyze

```
tests/topotest/analyze.py -C frr -Ar run-results
tests/topotests/analyze.py -C frr-ubuntu20 -Ar run-results
```

# Running
Expand All @@ -41,13 +41,13 @@ docker exec -it frr-ubuntu20 bash
# topotest -- when Host O/S is Ubuntu only

```
docker exec frr-ubuntu20 bash -c 'cd ~/frr/tests/topotests/ospf-topo1 ; sudo pytest test_ospf_topo1.py'
docker exec frr-ubuntu20 bash -c 'cd ~/frr/tests/topotests/ospf_topo1 ; sudo pytest test_ospf_topo1.py'
```

# stop & remove container

```
docker stop frr-ubuntu20 ; docker rm frr-ubuntu18
docker stop frr-ubuntu20 ; docker rm frr-ubuntu20
```

# remove image
Expand Down
14 changes: 7 additions & 7 deletions docker/ubuntu22-ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,43 +11,43 @@ docker build -t frr-ubuntu22:latest -f docker/ubuntu-ci/Dockerfile .
# Running Full Topotest

```
docker run --init -it --privileged --name frr -v /lib/modules:/lib/modules frr-ubuntu22:latest bash -c 'cd ~/frr/tests/topotests ; sudo pytest -nauto --dist=loadfile'
docker run --init -it --privileged --name frr-ubuntu22 -v /lib/modules:/lib/modules frr-ubuntu22:latest bash -c 'cd ~/frr/tests/topotests ; sudo pytest -nauto --dist=loadfile'
```

# Extract results from the above run into `run-results` dir and analyze

```
tests/topotest/analyze.py -C frr -Ar run-results
tests/topotests/analyze.py -C frr-ubuntu22 -Ar run-results
```

# Running

```
docker run -d --init --privileged --name frr --mount type=bind,source=/lib/modules,target=/lib/modules frr-ubuntu22:latest
docker run -d --init --privileged --name frr-ubuntu22 --mount type=bind,source=/lib/modules,target=/lib/modules frr-ubuntu22:latest
```

# make check

```
docker exec frr bash -c 'cd ~/frr ; make check'
docker exec frr-ubuntu22 bash -c 'cd ~/frr ; make check'
```

# interactive bash

```
docker exec -it frr bash
docker exec -it frr-ubuntu22 bash
```

# topotest -- when Host O/S is Ubuntu only

```
docker exec frr bash -c 'cd ~/frr/tests/topotests/ospf-topo1 ; sudo pytest test_ospf_topo1.py'
docker exec frr-ubuntu22 bash -c 'cd ~/frr/tests/topotests/ospf_topo1 ; sudo pytest test_ospf_topo1.py'
```

# stop & remove container

```
docker stop frr ; docker rm frr
docker stop frr-ubuntu22 ; docker rm frr-ubuntu22
```

# remove image
Expand Down

0 comments on commit 54134b4

Please sign in to comment.