Clear descriptors after stop

Thanks @cgimenes
donatj · Jan 22, 2024 · 1887dcb · 1887dcb
1 parent e166c98
commit 1887dcb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/MockWebServer.php b/src/MockWebServer.php
@@ -134,6 +134,8 @@ public function stop() : void {
 		foreach( $this->descriptors as $descriptor ) {
 			@fclose($descriptor);
 		}
+
+		$this->descriptors = [];
 	}
 
 	/**

diff --git a/test/Regression/MockWebServer_RegressionTest.php b/test/Regression/MockWebServer_RegressionTest.php
@@ -0,0 +1,20 @@
+<?php
+
+namespace Test\Regression;
+
+use donatj\MockWebServer\MockWebServer;
+use PHPUnit\Framework\TestCase;
+
+class MockWebServer_RegressionTest extends TestCase {
+
+	/**
+	 * @doesNotPerformAssertions
+	 */
+	public function test_stopTwiceShouldNotExplode() : void {
+		$server = new MockWebServer;
+		$server->start();
+		$server->stop();
+		$server->stop();
+	}
+
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -134,6 +134,8 @@ public function stop() : void { @@
     		foreach( $this->descriptors as $descriptor ) {
     			@fclose($descriptor);
     		}
+    		$this->descriptors = [];
     	}
     	/**
@@ Expand Down @@