Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for ruby 2.x & Rails 4.x #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

for ruby 2.x & Rails 4.x #25

wants to merge 1 commit into from

Conversation

hiphapis
Copy link

  • device.rb => remove attr_accessible
  • gcm_migrations_generator.rb => remove extend & add next_migration_number

@hiphapis
for rails 4
82207e6 
 - device.rb => remove attr_accessible
 - gcm_migrations_generator.rb => remove extend & add next_migration_number
@hiphapis
Copy link
Author

@dondeng ok. Thanks~ ;)

@kaosf
Copy link

kaosf commented Aug 21, 2013

A deplication warning occurs for me.

How do you guys think about my changes for it? kaosf@7c53b17

I have no idea why join is used there. So I'm not confident about my changes.

@kaosf
Copy link

kaosf commented Aug 23, 2013

I've added .readonly(false) at the tail of the default argument of send_notifications. It is necessary.

kaosf@596a813

@aledelsur
Copy link

Hi, I can't generate the gcm_migration because of the attr_accessible in the model Device.rb. I include this file in my project: lib/gcm_on_rails/app/models/gcm/device.rb so the attr_accessible line is not anymore. Did you guys faced with this problem?

I'm with rails 4.0.0 and ruby 2.0

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiphapis @kaosf @aledelsur @dondeng