Make data not to be nil when collapse_key is nil #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pull request #28 is merged,
collapse_key
ofnotification
can be nil.When it is nil,
data = notification.data.merge({:collapse_key => notification.collapse_key})
will not be executed, anddata
will become nil.Then, the next step of
data = data.merge({ ...
makes an error, becausedata
is nil.So, I modified it so that
data
is initialized bynotification.data
always.