Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data not to be nil when collapse_key is nil #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaosf
Copy link

@kaosf kaosf commented Aug 23, 2013

If the pull request #28 is merged, collapse_key of notification can be nil.

When it is nil, data = notification.data.merge({:collapse_key => notification.collapse_key}) will not be executed, and data will become nil.
Then, the next step of data = data.merge({ ... makes an error, because data is nil.

So, I modified it so that data is initialized by notification.data always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant