praxisdigital/moodle-block_sharing_cart#118 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new setting to "Copy activity"
Fix restore settings that cause restore issue Added moodle log when a sharing cart item got backup, restored or deleted
#111: Fix restore issue
Improve backup/restore process by using adhoc task Fix session lock error
Fix incorrect data type in restore controller
Limit to min. 100 characters in sharing cart item name
Add ellipsis when sharing cart item is exceed 97 characters in UTF-8 encoding
#119: Trim sharing cart item name
Improve sharing cart styling Fix restore in async mode, should rerun if backup hasn't been created
Fix backup controller try to delete backup after the backup process is done
#118: Add feature: async backup/restore - testet on Moodlefourtwo, both asyncron and normal copy, with and with out drag n drop, with and without user data.
Add support for Moodle 4.2
Fix upgrade script to clean up deleted user records Add event listener on user_deleted to remove user sharing cart items without waiting for privacy provider
#118: Add feature - async backup/restore
Fix upgrade script - MYSQL with danish cannot update character that is out of danish character range
|
Sorry, I don't understand the "All checks have failed." message. Should I try merging this? |
|
@donhinkelman I've fixed the issue. The tests are now green 🎉 This branch requires Moodle 4.2 or above - that is why the first check is failing. It tries to install the plugin on Moodle 4.1 - so that is expected. I will merge it :) |
frederikmillingpytlick
merged commit 72889ac
into
donhinkelman:master
3 of 4 checks passed
|
Ok, I will install in plugins database, noting that Moodle 4.2 is required. As well as PHP 7.4. |
|
@donhinkelman, the plugin requires PHP 7.4, but Moodle 4.2 requires PHP 8.0 So perhaps we should just say PHP 8.0? |
|
Got it. Sharing Cart 4.4, release 3 requires Moodle 4.2 and PHP 8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge praxisdigital/moodle-block_sharing_cart#118