Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with activity copy button #194

Merged

Conversation

AraPraxis
Copy link
Contributor

The activity copy button did not look at the section id on the courses correctly, this has now been fixed and should work on all course format in Moodle

(This has been "backported" to Moodle 4.1, which is the reason that no new release number has been added in the version directly, but info is given in the README.md)

@donhinkelman
Copy link
Owner

Please advise me, Anders, about which of these three pull requests I should merge with the base branch. I notice the success/fail checks in each pull request are different.

@AraPraxis
Copy link
Contributor Author

Hi @donhinkelman

All of the pull requests are for a different branch, and can all safely be merged.
The reason for the failing tests is that the specific PHP version dosen't work on those Moodle versions where it fails, and we haven't updated the test file, but will do so at a later date. It's only a notice, and it does not "harm" the plugin.

Kind regards,
Anders

@donhinkelman donhinkelman merged commit 097e245 into donhinkelman:MOODLE_41_STABLE Mar 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants