Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of sharing cart #208

Merged
merged 60 commits into from
Aug 5, 2024
Merged

New version of sharing cart #208

merged 60 commits into from
Aug 5, 2024

Conversation

frederikmillingpytlick
Copy link
Collaborator

No description provided.

frederikmillingpytlick and others added 30 commits February 20, 2024 15:50
@frederikmillingpytlick
Merge pull request donhinkelman#192 from praxisdigital/MOODLE_42_STABLE
ad70c7f 
Update MOODLE_42_STABLE
@AraPraxis
#102 - Fixed issue with activity copy button
3d0a1bc
@AraPraxis
#102 - Merge from MOODLE_42_STABLE
1cc8419
@Mikkeljeppesen1
Merge pull request #127 from praxisdigital/ara_GH-102_42
d987f32 
#102 - Fixed issue with activity copy button
@frederikmillingpytlick
#133 - Removed everything and started working on the initial block co…
a8b97f7 
…ntent
@frederikmillingpytlick
#133 - Started working on the frontend
3285054
@donhinkelman
Merge pull request donhinkelman#195 from praxisdigital/MOODLE_42_STABLE
737821c 
Fixed issue with activity copy button
@frederikmillingpytlick
#133 - Finished working on the frontend
621b744
@frederikmillingpytlick
#133 - Reimplemented basic backup
9bb581d
@frederikmillingpytlick
#133 - Added userdata & anonymize settings to backup
43463fc 
Added polling, so you don't have to refresh the page for items to update
@frederikmillingpytlick
#133 - Started working on the restore part
31820e9
@frederikmillingpytlick
#133 - Finished restore
ccb845b
@frederikmillingpytlick
#133 - Started working on restore queue
49d1c80
@frederikmillingpytlick
#133 - Finished working on both restore & backup queue
cbace7f
@frederikmillingpytlick
#133 - Reimplemented the user deleted event observer
f8295a9
@frederikmillingpytlick
#133 - Bumped version.php & updated README.md
3e33e47
@frederikmillingpytlick
#133 - Added upgrade script
d1a3b17
@frederikmillingpytlick
#133 - Fixed upgrade script
fa64191
@frederikmillingpytlick
#133 - Fixed last issues before test
dd57f06
@frederikmillingpytlick
#133 - Made changes according to PR feedback
c822691
@frederikmillingpytlick
#133 - Fixed upgrade script
81b9c03
@frederikmillingpytlick
#133 - Added legacy section explaination
37ac8fd 
Made sure the legacy icon persist on toggling collapse
@frederikmillingpytlick
#133 - Added sortable on the items
d3d5eb0
@frederikmillingpytlick
#133 - Add help text to restores not getting run
53a9c7e
@frederikmillingpytlick
#133 - Added drag & drop of sections and activities into the sharing …
8490428 
…cart
@frederikmillingpytlick
#133 - Delete multiple items at once
1800252
@frederikmillingpytlick
#133 - Fixed error when no section name is available
14c0f4a
@frederikmillingpytlick
#133 - Add todo
f09faf9
@frederikmillingpytlick
#133 - Improved error message when trying to copy an empty section
84ae426
@frederikmillingpytlick
#133 - Made a prettier error when trying to copy an empty section
48b2f22
frederikmillingpytlick and others added 27 commits May 7, 2024 14:01
@frederikmillingpytlick
#133 - Bumped version
cf90e5e
@frederikmillingpytlick
#133 - Fixed error where you could try to run a task multiple times
dcd7c1b
@frederikmillingpytlick
#133 - Fixed error where filters where not run on cm name
51f0312
@superfoght
Merge pull request #138 from praxisdigital/fmp_GH-133_42
08c8b94 
#133 - Bumped version
@frederikmillingpytlick
donhinkelman#200 - Fixed test
10fd796
@frederikmillingpytlick
Merge pull request #139 from praxisdigital/fmp_GH-200_42
3fd6fc2 
donhinkelman#200 - Fixed test
@frederikmillingpytlick
#144 - Added support for filter_multilang & fixed issue when copying …
66e8f74 
…a single activity
@frederikmillingpytlick
#145 - Add copy section button setting
7a4641d
@frederikmillingpytlick
#143 - Added notification to let people now they might need to refres…
7aee3ca 
…h for changes to be reflected correctly
@superfoght
Merge pull request #146 from praxisdigital/fmp_GH-144_42
f701c46 
#143, #144, #145, donhinkelman#200
@frederikmillingpytlick
#137 - Fixed issue with legacy items & optimized queue reloading, so …
f4bbef9 
…it prevents clicking run now multiple times
@frederikmillingpytlick
#137 - Updated javascript to handle wrong type
1ea594c
@neeesn
Merge pull request #147 from praxisdigital/fmp_GH-137_42
644a11b 
#137 - Fixed issue with legacy items & optimized queue reloading, so …
@frederikmillingpytlick
#148 - Fix issue with clicking multiple times on run now when backing…
5353d7c 
… up into sharing cart
@frederikmillingpytlick
Merge pull request #149 from praxisdigital/fmp_GH-148_42
3a23ce7 
#148 - Fix issue with clicking multiple times on run now when backing…
@frederikmillingpytlick
Fix issue where sharing cart would check capability in block context,…
b19ab50 
… instead of currently viewed course.

This could cause you not being able to use the block, if it was placed in system context
@frederikmillingpytlick
Merge pull request #151 from praxisdigital/fmp_fix_sharing_cart_capab…
b20fb09 
…ility_issue

Fix issue where sharing cart would check capability in block context,…
@frederikmillingpytlick
#150 - Update block strings
c7c5a75
@frederikmillingpytlick
Merge pull request #152 from praxisdigital/fmp_GH-150_42
5a36a78 
#150 - Update block strings
@frederikmillingpytlick
praxisdigital/moodle-block_sharing_cart#428 - Fix issue with javascri…
b03a6cc 
…pt preventing backup into sharing cart.

When the user did not have user data capabilities, the javascript threw an exception
@RayCoSector
Fixed for Moodle 4.4
919cf48 
Fix for area to place content in course page within Moodle 4.4
@Mikkeljeppesen1
Merge pull request #153 from praxisdigital/fmp_moodle-opgaver-GH-428_42
a754794 
praxisdigital/moodle-block_sharing_cart#428 - Fix issue with javascri…
@donhinkelman
Merge pull request donhinkelman#204 from RayCoSector/MOODLE_42_STABLE
9fc05a6 
Fixed for Moodle 4.4
@sampraxis
#154: Fix non-exists adhoc task
c231f5f 
Fix unable to (Run now) on non-exists adhoc task

Fix error when sharing cart try to poll non-exists item from plugin
@sampraxis
Merge pull request #155 from praxisdigital/smo_GH-154_42
e13cb77 
#154: Fix non-exists adhoc task
@frederikmillingpytlick
Merge remote-tracking branch 'fork/MOODLE_42_STABLE' into MOODLE_42_S…
2d5d07c 
…TABLE
@frederikmillingpytlick
Merge remote-tracking branch 'origin/MOODLE_42_STABLE'
0d5fa9a
@frederikmillingpytlick frederikmillingpytlick self-assigned this Aug 5, 2024
@frederikmillingpytlick frederikmillingpytlick merged commit 73dc376 into donhinkelman:master Aug 5, 2024
12 checks passed
@frederikmillingpytlick
Copy link
Collaborator Author

frederikmillingpytlick commented Aug 5, 2024 •
edited
Loading

Hi @donhinkelman, after a long time of development and testing, we're ready to release the new version of the sharing cart! (5.0, release 1 2024.08.05) on moodle.org 🥳

Here are some notes on what you should know when upgrading from the old version:
We've had to restructure the database, so the old sharing cart backups will behave a little different from before and the new backups you make in this version. See points below.

Old sharing cart items

  • Will be converted to the new format when you upgrade the plugin.
  • Once converted to the new format, you won't be able to restore these items all at once like before, but you can restore them one by one. You do this by expanding the section and clicking restore on the individual items.
  • Old sections converted to the new format will be marked as legacy with a yellow warning icon.

All of this is only for the old backups made before upgrading to this version. Backups made after upgrading will be able to restore whole sections at once like before (but faster and less error prone 😎).

also - it is no longer possible to move single activities between backed up sections in the sharing cart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frederikmillingpytlick frederikmillingpytlick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@frederikmillingpytlick @AraPraxis @Mikkeljeppesen1 @donhinkelman @superfoght @neeesn @RayCoSector @sampraxis