Skip to content

Support symfony/finder ^7.3 alongside ~6.4.0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support symfony/finder ^7.3 alongside ~6.4.0 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc2a4f
Allow symfony/finder ^7.1.
donquixote Jul 22, 2025
245efb2
Run CI with different symfony/finder versions.
donquixote Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,19 @@ jobs:
enable_yamllinter: true

unit-tests-linux:
name: "Unit tests, PHP ${{ matrix.php-versions }}, ${{ matrix.operating-system }}"
name: "Unit tests, PHP ${{ matrix.php-versions }}, symfony ${{ matrix.symfony }}, ${{ matrix.operating-system }}"
runs-on: ${{ matrix.operating-system }}
needs: [phplinter, linter]
strategy:
fail-fast: false
matrix:
operating-system: [ubuntu-latest]
php-versions: ['8.1', '8.2', '8.3', '8.4']
php-versions: ['8.2', '8.3', '8.4']
symfony: ['~6.4.0', '~7.1.0', '~7.2.0', '^7.3']
include:
- operating-system: 'ubuntu-latest'
php-versions: '8.1'
symfony: '~6.4.0'

steps:
- name: Setup PHP, with composer and extensions
Expand All @@ -71,6 +76,9 @@ jobs:

- uses: actions/checkout@v4

- name: "Require symfony/finder:${{ matrix.symfony }}"
run: composer require --no-update symfony/finder:${{ matrix.symfony }}

- name: Get composer cache directory
run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"

Expand All @@ -85,15 +93,15 @@ jobs:
run: composer install --no-progress --prefer-dist --optimize-autoloader

- name: Run unit tests with coverage
if: ${{ matrix.php-versions == '8.4' }}
if: ${{ matrix.php-versions == '8.4' && matrix.symfony == '' }}
run: vendor/bin/phpunit

- name: Run unit tests (no coverage)
if: ${{ matrix.php-versions != '8.4' }}
if: ${{ matrix.php-versions != '8.4' || matrix.symfony != '' }}
run: vendor/bin/phpunit --no-coverage

- name: Save coverage data
if: ${{ matrix.php-versions == '8.4' }}
if: ${{ matrix.php-versions == '8.4' && matrix.symfony == '' }}
uses: actions/upload-artifact@v4
with:
name: coverage-data
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

"simplesamlphp/assert": "~1.8.1",
"simplesamlphp/composer-xmlprovider-installer": "~1.0.2",
"symfony/finder": "~6.4.0"
"symfony/finder": "~6.4.0|^7.1"
},
"require-dev": {
"simplesamlphp/simplesamlphp-test-framework": "~1.9.2"
Expand Down