Support symfony/finder ^7.1 alongside ~6.4.0 (fork) #3
Conversation
donquixote
changed the title
| include: | ||
| - operating-system: 'ubuntu-latest' | ||
| php-versions: '8.1' | ||
| symfony: '~6.4.0' |
There was a problem hiding this comment.
Maybe this full version range is a bit overkill, but it confirms that we can use ^7.1 rather than ^7.3 in composer.json.
In fact ^7.0 would also work, but Drupal only ever needs ^7.1 starting at drupal/core:11.0.0.
composer.json
Outdated
| "simplesamlphp/assert": "~1.8.1", | ||
| "simplesamlphp/composer-xmlprovider-installer": "~1.0.2", | ||
| "symfony/finder": "~6.4.0" | ||
| "symfony/finder": "~6.4.0|^7.1" |
There was a problem hiding this comment.
Why not using double pipes?
| "symfony/finder": "~6.4.0|^7.1" | |
| "symfony/finder": "~6.4.0 || ^7.1" |
There was a problem hiding this comment.
Another thing is, what is the minimum version?
There was a problem hiding this comment.
Ok, I did not remember what is the preferred way to do it. Going to change it to ||.
.github/workflows/php.yml
Outdated
| operating-system: [ubuntu-latest] | ||
| php-versions: ['8.1', '8.2', '8.3', '8.4'] | ||
| php-versions: ['8.2', '8.3', '8.4'] | ||
| symfony: ['~6.4.0', '~7.1.0', '~7.2.0', '^7.3'] |
There was a problem hiding this comment.
I wonder if we should test all minors available or just the same as composer.
For me it's just the latest or min-latest.
In the future if new minors are released you have to manually add them, and the CI takes more and more time.
There was a problem hiding this comment.
maybe we reduce it to ^6.4, ~7.1.0 and ^7.3, just to be sure that our min version is ok.
Keep in mind ^7.3 one will always take the last from 7.x, so that could be 7.4.* or 7.5.* in the future.
donquixote
force-pushed
the
fork/upgrade-symfony-finder
branch
from
e0e3e95 to
245efb2
Compare
donquixote
force-pushed
the
fork/upgrade-symfony-finder
branch
from
245efb2 to
dcd20f9
Compare
donquixote
force-pushed
the
fork/upgrade-symfony-finder
branch
from
dcd20f9 to
b79fe59
Compare
|
That's great! |
Uh oh!
There was an error while loading. Please reload this page.