Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the substract effect show a negative number #17

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

5jiji
Copy link
Contributor

@5jiji 5jiji commented Feb 24, 2024

No description provided.

@5jiji 5jiji changed the title Made the substract effect effect show a negative number Made the substract effect show a negative number Feb 24, 2024
@doodlechaos
Copy link
Owner

There is some nuance to this. I intentionally left it out to save room on the bucket so the text doesn't get too small with big numbers. I made the red background indicate that it subtracts. If the majority of people think this tradeoff is worth it, I'm willing to change it though.

@Andre601
Copy link
Contributor

There is some nuance to this. I intentionally left it out to save room on the bucket so the text doesn't get too small with big numbers. I made the red background indicate that it subtracts. If the majority of people think this tradeoff is worth it, I'm willing to change it though.

My main argument for this change is a11y.
A person with a red color blindness may not be able to determine that this particular bucket would take points from a person. Especially when they have a red-green color blindness and the other buckets have a green hue to them.

@Andre601
Copy link
Contributor

If having the - directly shown still isn't appealing to you doodle, why not make it a setting to toggle?
That way can people who want it have that displayed while others don't.

@doodlechaos
Copy link
Owner

I would be okay to merge it if it was a toggle that defaults to off in the config 👍

@5jiji
Copy link
Contributor Author

5jiji commented Feb 28, 2024

I'm making it up right now!

@5jiji
Copy link
Contributor Author

5jiji commented Feb 29, 2024

The negative effect new works with a config variable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants