Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming nit: "Generate Test Report" instead of "Test Report" #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Naming nit: "Generate Test Report" instead of "Test Report" #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- run: npm ci # install packages
- run: npm test # run tests (configured to use jest-junit reporter)

- name: Test Report
- name: Generate Test Report
uses: dorny/test-reporter@v1
if: success() || failure() # run this step even if previous step failed
with:
Expand All @@ -56,7 +56,7 @@ jobs:
Workflows triggered by pull requests from forked repositories are executed with read-only token and therefore can't create check runs.
To workaround this security restriction, it's required to use two separate workflows:
1. `CI` runs in the context of the PR head branch with the read-only token. It executes the tests and uploads test results as a build artifact
2. `Test Report` runs in the context of the repository main branch with read/write token. It will download test results and create reports
2. `Generate Test Report` runs in the context of the repository main branch with read/write token. It will download test results and create reports

**PR head branch:** *.github/workflows/ci.yml*
```yaml
Expand All @@ -76,9 +76,9 @@ jobs:
name: test-results
path: jest-junit.xml
```
**default branch:** *.github/workflows/test-report.yml*
**default branch:** *.github/workflows/generate-test-report.yml*
```yaml
name: 'Test Report'
name: 'Generate Test Report'
on:
workflow_run:
workflows: ['CI'] # runs after CI workflow
Expand Down